Allow evaluate_script to return values

[metajack]

This includes some other minor cleanups. This is a port of @tschneidereit's commits from this branch: https://github.com/tschneidereit/rust-mozjs/tree/update-bindings

This is need to get https://github.com/tschneidereit/mozjs-shell working.

---

This change is

[metajack]

r? @nox or @jdm or @tschneidereit

[jdm]

The last commit will require nontrivial changes in Servo, I think. I'd rather have it separate from the rest of these changes.

[metajack]

I'm not actually sure why it is need here. @till? I'm happy to remove it from this PR.

[metajack]

Sorry @till. I meant @tschneidereit.

[tschneidereit]

The last commit will require nontrivial changes in Servo, I think. I'd rather have it separate from the rest of these changes.

It's not required. We should do the required changes to Servo anyway because long-term contexts will go away (and their uses be replaced by JSRuntime), and because there's no upside to using multiple contexts in Servo. But there's no need to do this now.

[tschneidereit]

I think only the first commit is needed. The second one makes sense, though, so we should keep it.

[jdm]

@tschneidereit We only use one context. The commit in question is about requests.

[tschneidereit]

@tschneidereit We only use one context. The commit in question is about requests.

Hrm, sorry - it's been a while since I looked at all this and I misremembered stuff. What I really meant was that, AFAICT, there's no need to ever enter more than one request - or leave that request. We don't call js::SetActivityCallback, and I'm pretty sure that's the only thing triggered by rt->requestDepth being set to or changed from 0.

Then again, it doesn't matter much at all whether we do or do not do this, so we can just ignore it.

[Ms2ger]

We should call into jsapi with null for perf reasons, iirc; this PR doesn't change that, though.

[nox]

Can we mark evaluate_script as unsafe? Especially if it doesn't use JSAutoRequest even though it crashes without it.

[Ms2ger]

Not entirely relatedly: maybe we should make evaluate_script a free function that takes *mut JSContext? The implementation shouldn't need a Runtime, and it can be annoying to get your hands on one.

[bors-servo]

:umbrella: The latest upstream changes (presumably #260) made this pull request unmergeable. Please resolve the merge conflicts.

[metajack]

Rebased and dropped the last commit. Ready for rereview.

[jdm]

@bors-servo: r+

[bors-servo]

:pushpin: Commit 73028b8 has been approved by jdm

[bors-servo]

:hourglass: Testing commit 73028b8 with merge 8ad6c11...

[bors-servo]

:sunny: Test successful - travis

[metajack]

@nox did you include this in your smup somehow? This hasn't landed but now mozjs-shell is working as expected, so I'm totally confused.

[metajack]

oh, nm. github hadn't updated the page, and I was looking at stale data.