Consider having Runtime::new enter a request

servo / rust-mozjs

DEPRECATED - moved to servo/mozjs instead.

Mozilla Public License 2.0

293 stars 117 forks source link

Consider having Runtime::new enter a request #259

Closed Ms2ger closed 8 years ago

Ms2ger commented 8 years ago

https://github.com/servo/rust-mozjs/pull/258#issuecomment-213615809

AFAICT, there's no need to ever enter more than one request - or leave that request. We don't call js::SetActivityCallback, and I'm pretty sure that's the only thing triggered by rt->requestDepth being set to or changed from 0.

If that's true, we wouldn't have to deal with requests in any code downstream of this crate (which would make me very happy!).

tschneidereit commented 8 years ago

07:43 jorendorff: what are requests for nowadays? 07:44 yeah, not much - it's vestigial 07:44 we should rip it out 07:50 till: I don't think there's any interaction with requests in the rooting api

Ms2ger commented 8 years ago

See also discussion in https://bugzilla.mozilla.org/show_bug.cgi?id=1267297