search

servo / rust-mozjs

DEPRECATED - moved to servo/mozjs instead.
Mozilla Public License 2.0
293 stars 122 forks source link

Replace return_address usage in Rooted with a stack guard and a rooted! macro. #272

Closed eddyb closed 8 years ago

eddyb commented 8 years ago

Part of a potential solution for rust-lang/rust#34227.

This change is Reviewable

Ms2ger commented 8 years ago

Others should review this too, but I think this is good enough.

CC @nox @Manishearth @jdm

nox commented 8 years ago

LGTM too.

Manishearth commented 8 years ago

Overall lgtm. would like more docs.

Manishearth commented 8 years ago

@bors-servo r+

Ms2ger commented 8 years ago

@bors-servo r=Manishearth

bors-servo commented 8 years ago

:pushpin: Commit 3e1be4a has been approved by Manishearth

Ms2ger commented 8 years ago

@bors-servo retry

Ms2ger commented 8 years ago

@bors-servo clean retry

Ms2ger commented 8 years ago

@bors-servo r=Manishearth

bors-servo commented 8 years ago

:pushpin: Commit ae62516 has been approved by Manishearth

bors-servo commented 8 years ago

:hourglass: Testing commit ae62516 with merge 9ddac71...

bors-servo commented 8 years ago

:broken_heart: Test failed - travis

cbrewster commented 8 years ago

@bors-servo r=Manishearth

bors-servo commented 8 years ago

:pushpin: Commit 71333b8 has been approved by Manishearth

bors-servo commented 8 years ago

:hourglass: Testing commit 71333b8 with merge 7ccfee5...

bors-servo commented 8 years ago

:sunny: Test successful - travis