Enable cross-crate inlining for JSVal conversion methods.

servo / rust-mozjs

DEPRECATED - moved to servo/mozjs instead.

Mozilla Public License 2.0

293 stars 122 forks source link

Enable cross-crate inlining for JSVal conversion methods. #276

Closed jdm closed 8 years ago

jdm commented 8 years ago

Make it possible for Rust methods which are called in the generated bindings to be inlined. This shaved off 1/3-1/2 of the total time in the measurements in https://github.com/servo/servo/issues/12354.

This change is

emilio commented 8 years ago

@bors-servo: r+

Doesn't rust inline this kind of methods cross-crate by default? Why?

bors-servo commented 8 years ago

:pushpin: Commit 10142b4 has been approved by emilio

bors-servo commented 8 years ago

:hourglass: Testing commit 10142b4 with merge 3ea6213...

bors-servo commented 8 years ago

:sunny: Test successful - travis

jdm commented 8 years ago

Cross-crate inline doesn't happen without the annotation as far as I know.