search

servo / rust-mozjs

DEPRECATED - moved to servo/mozjs instead.
Mozilla Public License 2.0
293 stars 122 forks source link

Rewrite FromJSValConvertible to better support unions #284

Closed GuillaumeGomez closed 8 years ago

GuillaumeGomez commented 8 years ago

Fixes #282.

This change is Reviewable

GuillaumeGomez commented 8 years ago

r? @nox

GuillaumeGomez commented 8 years ago

Updated.

Ms2ger commented 8 years ago

convert_int_from_jsval and enforce_range need to be changed to return Result<ConversionResult<D/T>, ()>

GuillaumeGomez commented 8 years ago

Updated.

Ms2ger commented 8 years ago

@bors-servo r+

Ms2ger commented 8 years ago

@bors-servo r+

bors-servo commented 8 years ago

:pushpin: Commit 9a01c9d has been approved by Ms2ger

bors-servo commented 8 years ago

:hourglass: Testing commit 9a01c9d with merge cac3beb...

bors-servo commented 8 years ago

:broken_heart: Test failed - status-travis

Ms2ger commented 8 years ago

@bors-servo r+

bors-servo commented 8 years ago

:pushpin: Commit 9b2e4ad has been approved by Ms2ger

bors-servo commented 8 years ago

:hourglass: Testing commit 9b2e4ad with merge daffcfb...

bors-servo commented 8 years ago

:sunny: Test successful - status-appveyor, status-travis