servo / rust-mozjs

DEPRECATED - moved to servo/mozjs instead.
Mozilla Public License 2.0
293 stars 117 forks source link

Review soundness of ObjectValue and friends. #292

Closed nox closed 8 years ago

nox commented 8 years ago

These functions take a &JSObject, but JSObject is an empty type. This is worrying because doing just *obj on it is UB.

Ms2ger commented 8 years ago

Yeah, that was a stupid idea on my part. It should just take *mut JSObject.

DemiMarie commented 8 years ago

I have a PR coming – just doing a local build.

emilio commented 8 years ago

This is fixed now.