Update etc/bindings.sh for the new bindgen flag format

servo / rust-mozjs

DEPRECATED - moved to servo/mozjs instead.

Mozilla Public License 2.0

293 stars 117 forks source link

Closed fitzgen closed 8 years ago

fitzgen commented 8 years ago

r? @emilio

This change is

emilio commented 8 years ago

I'd have expected you to need to put wrapper.h after everything else, but if not, r=me

emilio commented 8 years ago

@bors-servo: delegate+ (not sure if you have bors-superpowers)

bors-servo commented 8 years ago

:v: @fitzgen can now approve this pull request

fitzgen commented 8 years ago

I'd have expected you to need to put wrapper.h after everything else, but if not, r=me

It is after all the normal flags, but before -- and the flags that get passed through to clang.

emilio commented 8 years ago

@fitzgen: Yeah, I mean, for the -x c++ -std=c++11 to be effective, I think you need to give the filename after it?

Anyway, I guess you've tested it, so feel free to invoke bors with r=emilio

fitzgen commented 8 years ago

@bors-servo r=emilio

bors-servo commented 8 years ago

:pushpin: Commit 1e71c1e has been approved by emilio

bors-servo commented 8 years ago

:hourglass: Testing commit 1e71c1e with merge bbf907b...

bors-servo commented 8 years ago