Implement maybe_wrap_object_value without OOL calls

servo / rust-mozjs

DEPRECATED - moved to servo/mozjs instead.

Mozilla Public License 2.0

293 stars 122 forks source link

Closed nox closed 7 years ago

nox commented 8 years ago

The only remaining OOL calls are ToWindowIfWindowProxy and JS_WrapValue, like in the equivalent Gecko function.

This change is

nox commented 8 years ago

Amended all the things.

Ms2ger commented 8 years ago

Code looks okay to me; I'd like @jdm to agree we want to go this way, though.

(Also, some documentation might be useful.)

bors-servo commented 8 years ago

:umbrella: The latest upstream changes (presumably #305) made this pull request unmergeable. Please resolve the merge conflicts.

jdm commented 7 years ago

Planning to finish this up, @nox?

jdm commented 7 years ago

@bors-servo: r+

bors-servo commented 7 years ago

:pushpin: Commit f32c5ac has been approved by jdm

bors-servo commented 7 years ago

:hourglass: Testing commit f32c5ac with merge 3ac1492...

bors-servo commented 7 years ago