search

servo / rust-mozjs

DEPRECATED - moved to servo/mozjs instead.
Mozilla Public License 2.0
293 stars 122 forks source link

Improve typed array support. #304

Closed Ms2ger closed 8 years ago

Ms2ger commented 8 years ago

This change is Reviewable

Ms2ger commented 8 years ago

r? @jdm

jdm commented 8 years ago

I am super pumped to look at this later today!

jdm commented 8 years ago

As for the neutering stuff, I've spent a while looking at Gecko's implementation and thinking about whether we can do anything better, and I haven't come up with any good ideas. APIs like TypedArray::with_slice could accept a closure, but that wouldn't prevent people from running JS that could invalidate the slice inside of the closure, so it would still be unsafe and less pleasant to use.

Ms2ger commented 8 years ago

Still needs tests.

Ms2ger commented 8 years ago

Tests done, r? @jdm

jdm commented 8 years ago

@bors-servo: r+ Thanks!

bors-servo commented 8 years ago

:pushpin: Commit da0665d has been approved by jdm

bors-servo commented 8 years ago

:hourglass: Testing commit da0665d with merge fc380e0...

bors-servo commented 8 years ago

:sunny: Test successful - status-appveyor, status-travis