Move code from TypedArray::create and Add TypedArray::update

servo / rust-mozjs

DEPRECATED - moved to servo/mozjs instead.

Mozilla Public License 2.0

293 stars 122 forks source link

Closed yysung1123 closed 7 years ago

yysung1123 commented 7 years ago

For servo/servo#15350

TypedArray::update is used to be replace update_array_buffer_view

This change is

yysung1123 commented 7 years ago

Should I replace all data: Option<&[T::Element]> with data: <&[T::Element]>?

jdm commented 7 years ago

Yes, that would lead to a cleaner API.

jdm commented 7 years ago

Not sure why my last comment is marked outdated, but please look at it as well.

yysung1123 commented 7 years ago

@jdm

About panic test? I have added it already!

yysung1123 commented 7 years ago

Conflicts resolved

jdm commented 7 years ago

@bors-servo: r+ Thanks!

bors-servo commented 7 years ago

:pushpin: Commit af187fb has been approved by jdm

bors-servo commented 7 years ago

:hourglass: Testing commit af187fb with merge 4c4e850...

bors-servo commented 7 years ago

:sunny: Test successful - status-appveyor, status-travis Approved by: jdm Pushing 4c4e850aae31f8d9823fd57fa07e8f1da8618580 to master...