added servojsprincipal skeleton

servo / rust-mozjs

DEPRECATED - moved to servo/mozjs instead.

Mozilla Public License 2.0

293 stars 122 forks source link

added servojsprincipal skeleton #353

Closed avadacatavra closed 7 years ago

avadacatavra commented 7 years ago

Cross origin wrappers (https://github.com/servo/servo/pull/16501) require JSPrincipals. This PR adds the skeleton and basic functionality required.

CC: @jdm

This change is

asajeffrey commented 7 years ago

Annoying bikeshedding... is rust-mozjs intended to be servo-specific, or general rust bindings to SM for anyone to play with? If the latter, should ServoJSPrincipal have a less servo-specific name?

jdm commented 7 years ago

RustJSPrincipal would be fine.

jdm commented 7 years ago

Squash and r=me.

avadacatavra commented 7 years ago

r=@jdm

emilio commented 7 years ago

@bors-servo r=jdm

bors-servo commented 7 years ago

:pushpin: Commit dea774c has been approved by jdm

bors-servo commented 7 years ago

:hourglass: Testing commit dea774c3a095d7b2573806aa76d9eec9e2725dde with merge 3d8c269902721e875098b40997b1db9293f3e590...

bors-servo commented 7 years ago

:sunny: Test successful - status-appveyor, status-travis Approved by: jdm Pushing 3d8c269902721e875098b40997b1db9293f3e590 to master...

fitzgen commented 7 years ago

is rust-mozjs intended to be servo-specific, or general rust bindings to SM for anyone to play with?

Eventually, it should be for general SM embedding. There is a fair amount of work that needs to happen to make this a reality after the bindings land in m-c, still. A lot of the generic GC-related infrastructure is in Servo's dom component, for example.