servo / rust-mozjs

DEPRECATED - moved to servo/mozjs instead.
Mozilla Public License 2.0
293 stars 122 forks source link

Upgrade to rustc 1.19.0-nightly (ced823e26 2017-05-07) #358

Closed SimonSapin closed 7 years ago

SimonSapin commented 7 years ago

This change is Reviewable

nox commented 7 years ago

@bors-servo r+

bors-servo commented 7 years ago

:pushpin: Commit 61dc5c9 has been approved by nox

bors-servo commented 7 years ago

:hourglass: Testing commit 61dc5c9e4047a220f46078e3be44d82a9e1f4762 with merge a88d705e7b9accef3085e7003edb88f4493c87a3...

SimonSapin commented 7 years ago

Travis fails because https://github.com/rust-lang/rust/pull/41064 hasn’t reached Nigthly yet. Tested locally with rustc 1.19.0-nightly (ced823e26 2017-05-07).

cargo test --features debugmozjs shows:

WARNING: YOU ARE LEAKING THE WORLD (at least one JSRuntime and everything alive inside it, that is) AT JS_ShutDown TIME. FIX THIS!

… but it already did in https://travis-ci.org/servo/rust-mozjs/jobs/225720367.

bors-servo commented 7 years ago

:broken_heart: Test failed - status-travis