search

servo / rust-mozjs

DEPRECATED - moved to servo/mozjs instead.
Mozilla Public License 2.0
293 stars 122 forks source link

bindings-all.py passing unknown params to bindgen #363

Open RReverser opened 7 years ago

RReverser commented 7 years ago

These params cause bindgen to throw errors:

  --no-class-constants \
  --no-type-renaming \
...
  --allow-unknown-types \
...
  --match ...

Could you clarify if these are simply outdated or you're using some private fork of bindgen with support for these? If the latter, any chance to send changes upstream so that we could all run bindings generator?

jdm commented 7 years ago

It's much more likely that the code in the tree is using an outdated version than a private fork.

RReverser commented 7 years ago

Yeah looks like that. For example, allow-unknown-types: https://github.com/servo/rust-bindgen/commit/8ed69e853f249e71c7b1f8f24b0297f2473d1e31

But then, there is no analogy for --match in up-to-date version, and the script seems to heavily rely on it to filter files instead of functions/types/...

jdm commented 7 years ago

There's ongoing work to integrate this work with upstream Spidermonkey automatically, which is really the future of this repository: https://bugzilla.mozilla.org/show_bug.cgi?id=1277338