search

servo / rust-mozjs

DEPRECATED - moved to servo/mozjs instead.
Mozilla Public License 2.0
293 stars 122 forks source link

Rewrote documentation for conversion failure modes. #364

Closed asajeffrey closed 7 years ago

asajeffrey commented 7 years ago

Improved the documentation about when from_jsval is expected to produce a pending JSAPI exception.

This change is Reviewable

asajeffrey commented 7 years ago

r? @nox

asajeffrey commented 7 years ago

IRC conversation: http://logs.glob.uno/?c=mozilla%23servo&s=5+Jun+2017&e=5+Jun+2017&h=nox#c689485

nox commented 7 years ago

@bors-servo r+

Thanks.

bors-servo commented 7 years ago

:pushpin: Commit 20b7aa0 has been approved by nox

bors-servo commented 7 years ago

:hourglass: Testing commit 20b7aa0f4d40690ccdbe6a030116a0856ecdd35f with merge 75a97e9bafd3927b05c05eef65981b315a9a41d4...

bors-servo commented 7 years ago

:sunny: Test successful - status-appveyor, status-travis Approved by: nox Pushing 75a97e9bafd3927b05c05eef65981b315a9a41d4 to master...