search

servo / rust-mozjs

DEPRECATED - moved to servo/mozjs instead.
Mozilla Public License 2.0
293 stars 122 forks source link

Remove FromJSValConvertible implementation for HandleValue #388

Closed Xanewok closed 6 years ago

Xanewok commented 6 years ago

Needed for https://github.com/servo/servo/pull/19644.

Removes FromJSValConvertible implementations for HandleValue, so Vec<HandleValue> conversion is impossible. Also adds the implementation for *mut JSObject so the sequence<object> -> CustomAutoRooterGuard<Vec<*mut JSObject>> conversion works.

This change is Reviewable

jdm commented 6 years ago

I'm going to hold off on merging this until the Servo PR is ready to merge.

jdm commented 6 years ago

@bors-servo: r+

bors-servo commented 6 years ago

:pushpin: Commit 2f473fa has been approved by jdm

bors-servo commented 6 years ago

:hourglass: Testing commit 2f473fa799ca70277e54babb8d55ad90f6fb87b3 with merge ad8f138e4b9465569e045d34a0cb4097689489ca...

jdm commented 6 years ago

@bors-servo: r- Let's increase the version number so we can publish this.

Xanewok commented 6 years ago

Bumped to 0.1.10.

jdm commented 6 years ago

@bors-servo: r+

bors-servo commented 6 years ago

:pushpin: Commit 81e042f has been approved by jdm

bors-servo commented 6 years ago

:hourglass: Testing commit 81e042f36174ae90d5d2fee0d355f52bf5fa9fd4 with merge 5e79529f6cb7c0b82a484404d034bbafc130c9fa...

bors-servo commented 6 years ago

:broken_heart: Test failed - status-appveyor

jdm commented 6 years ago

The appveyor problem will go away once https://github.com/servo/rust-mozjs/pull/389 is merged.

jdm commented 6 years ago

@bors-servo: retry

bors-servo commented 6 years ago

:hourglass: Testing commit 81e042f36174ae90d5d2fee0d355f52bf5fa9fd4 with merge d829b21368f5142865b410f706f841683d9228a0...

bors-servo commented 6 years ago

:sunny: Test successful - status-appveyor, status-travis Approved by: jdm Pushing d829b21368f5142865b410f706f841683d9228a0 to master...