search

servo / rust-mozjs

DEPRECATED - moved to servo/mozjs instead.
Mozilla Public License 2.0
293 stars 122 forks source link

Don't test on x86_64-pc-windows-gnu #389

Closed jdm closed 6 years ago

jdm commented 6 years ago

This change is Reviewable

jdm commented 6 years ago

This is working around this failure that has appeared since the last successful rust-mozjs merge:

  = note: C:\projects\rust-mozjs\target\debug\deps\libmozjs_sys-c4a814893ed44c2b.rlib(Unified_cpp_js_src24.o): In function `printf':
          C:/msys64/mingw64/x86_64-w64-mingw32/include/stdio.h:340: undefined reference to `__imp___acrt_iob_func'
          C:\projects\rust-mozjs\target\debug\deps\libmozjs_sys-c4a814893ed44c2b.rlib(Unified_cpp_js_src24.o): In function `MOZ_ReportAssertionFailure':
          C:/projects/rust-mozjs/target/debug/build/mozjs_sys-55f43d0ca45a91bc/out/dist/include/mozilla/Assertions.h:160: undefined reference to `__imp___acrt_iob_func'
          C:/projects/rust-mozjs/target/debug/build/mozjs_sys-55f43d0ca45a91bc/out/dist/include/mozilla/Assertions.h:160: undefined reference to `__imp___acrt_iob_func'
          C:/projects/rust-mozjs/target/debug/build/mozjs_sys-55f43d0ca45a91bc/out/dist/include/mozilla/Assertions.h:160: undefined reference to `__imp___acrt_iob_func'
          C:/projects/rust-mozjs/target/debug/build/mozjs_sys-55f43d0ca45a91bc/out/dist/include/mozilla/Assertions.h:160: undefined reference to `__imp___acrt_iob_func'
          C:\projects\rust-mozjs\target\debug\deps\libmozjs_sys-c4a814893ed44c2b.rlib(Unified_cpp_js_src24.o):C:/projects/rust-mozjs/target/debug/build/mozjs_sys-55f43d0ca45a91bc/out/dist/include/mozilla/Assertions.h:160: more undefined references to `__imp___acrt_iob_func' follow

Since we don't use non-msvc windows builds for Servo, I'm not going to spend any time investigating it.

mbrubeck commented 6 years ago

@bors-servo r+

bors-servo commented 6 years ago

:pushpin: Commit 36d50bc has been approved by mbrubeck

bors-servo commented 6 years ago

:hourglass: Testing commit 36d50bc5822fdbfb72a105c0e37829203e44f52e with merge 31c80d117744657d97f02634c0edd92fc074c1a4...

bors-servo commented 6 years ago

:sunny: Test successful - status-appveyor, status-travis Approved by: mbrubeck Pushing 31c80d117744657d97f02634c0edd92fc074c1a4 to master...