Add a conversion from the newly-#[stable] `ptr::NonNull` type

servo / rust-mozjs

DEPRECATED - moved to servo/mozjs instead.

Mozilla Public License 2.0

293 stars 117 forks source link

Add a conversion from the newly-#[stable] `ptr::NonNull` type #390

Closed SimonSapin closed 6 years ago

SimonSapin commented 6 years ago

This will allow removing the NonNullJSObjectPtr hack in Servo, but raises the minimum Rust version to 1.25 (currently Nigthly)

This change is

SimonSapin commented 6 years ago

@fitzgen @jdm @nox How do you feel about this repository requiring Rust ~~1.15~~ 1.25? According to https://wiki.mozilla.org/Rust_Update_Policy_for_Firefox Gecko can use that version from April 12, but as far as I understand it doesn’t use this repo anyway.

nox commented 6 years ago

I assume you meant 1.25? I don't mind.

SimonSapin commented 6 years ago

Oops, yes. I mostly ask in case it interferes with plans to unify this repo with js/ in mozilla-central.

SimonSapin commented 6 years ago

In particular: this is only clean-up, so if it requires adding a Cargo feature somewhere it’s not worth it and we can just wait.

SimonSapin commented 6 years ago

I take it "approved" means:

@bors-servo r=jdm

bors-servo commented 6 years ago

:pushpin: Commit 5a68234 has been approved by jdm

bors-servo commented 6 years ago

:hourglass: Testing commit 5a682343f61fec25d4abbaab4bda7775a51486dd with merge 8f5cf86790b03b63e8bd2cbf580c941daa83793d...

bors-servo commented 6 years ago

:boom: Test timed out

KiChjang commented 6 years ago

@bors-servo retry

bors-servo commented 6 years ago

:hourglass: Testing commit 5a682343f61fec25d4abbaab4bda7775a51486dd with merge d5aabe3e21c7ffe53861c152f963b46a86216089...

SimonSapin commented 6 years ago

Eh, OS X job on Travis-CI still not scheduled after 13 hours…

bors-servo commented 6 years ago

:sunny: Test successful - status-appveyor, status-travis Approved by: jdm Pushing d5aabe3e21c7ffe53861c152f963b46a86216089 to master...