Remove Heap::new constructor

servo / rust-mozjs

DEPRECATED - moved to servo/mozjs instead.

Mozilla Public License 2.0

293 stars 122 forks source link

Remove Heap::new constructor #398

Closed Xanewok closed 6 years ago

Xanewok commented 6 years ago

Closes #343.

This removes the Heap::new constructor and adds a bit more info/explanation how Heap works and why it's not safe to move it after setting the value.

This bumps minor version again since the API changes are breaking and I think this should not be merged until Servo PR (which I'll send later) passes tests/is good enough with these changes.

This change is

jdm commented 6 years ago

@bors-servo r+

bors-servo commented 6 years ago

:pushpin: Commit d8b6ae7 has been approved by jdm

bors-servo commented 6 years ago

:hourglass: Testing commit d8b6ae7fcff342c2fddca8df5a7556bcc3b9e415 with merge 59d390f3f42e2224a42bd4bdfba42b6e8c1df19f...

bors-servo commented 6 years ago

:sunny: Test successful - status-appveyor, status-travis Approved by: jdm Pushing 59d390f3f42e2224a42bd4bdfba42b6e8c1df19f to master...