Sanitize Heap::handle(_mut) functions

servo / rust-mozjs

DEPRECATED - moved to servo/mozjs instead.

Mozilla Public License 2.0

293 stars 122 forks source link

Closed Xanewok closed 6 years ago

Xanewok commented 6 years ago

Fixes #351.

Also marked Heap::handle as unsafe, hopefully the explanation in the code is concise/good enough.

r? @jdm

This change is

jdm commented 6 years ago

@bors-servo r+ Hooray for getting rid of footguns!

bors-servo commented 6 years ago

:pushpin: Commit 8401624 has been approved by jdm

bors-servo commented 6 years ago

:hourglass: Testing commit 84016241e37a89efd4414a3f8b7a9d2f757a0ac8 with merge 8fe9be3fabad5ebe95dca9b3eceb4a3a3ac052da...

bors-servo commented 6 years ago

:sunny: Test successful - status-appveyor, status-travis Approved by: jdm Pushing 8fe9be3fabad5ebe95dca9b3eceb4a3a3ac052da to master...