search

servo / rust-mozjs

DEPRECATED - moved to servo/mozjs instead.
Mozilla Public License 2.0
293 stars 122 forks source link

Added RootKind and GCMethods implementation for PropertyDescriptor #414

Closed taki-jaro closed 6 years ago

taki-jaro commented 6 years ago

It is needed for servo issue 15012.

This change is Reviewable

jdm commented 6 years ago

@bors-servo r+

bors-servo commented 6 years ago

:pushpin: Commit 18ea0f8 has been approved by jdm

bors-servo commented 6 years ago

:umbrella: The latest upstream changes (presumably #393) made this pull request unmergeable. Please resolve the merge conflicts.

bors-servo commented 6 years ago

:lock: Merge conflict

taki-jaro commented 6 years ago

Why this stiil isn't merged 2 hours after passing tests and approval?

jdm commented 6 years ago

I didn't think there was any particular rush, since there's still debugging happening for the test failures, right? I've been too hasty merging other PRs like the handle one while the Servo PR isn't ready yet.

taki-jaro commented 6 years ago

No there is no particular rush.I was just surprised and thought there is a problem on my side.

KiChjang commented 6 years ago

@taki-jaro Could you rebase your commits against the master branch instead of merging? Once you've done that, you can instruct bors-servo to r=jdm.

@bors-servo delegate+

bors-servo commented 6 years ago

:v: @taki-jaro can now approve this pull request

taki-jaro commented 6 years ago

@bors-servo r=jdm

bors-servo commented 6 years ago

:pushpin: Commit 3e5024a has been approved by jdm

bors-servo commented 6 years ago

:hourglass: Testing commit 3e5024a3bcb4dafb71a32bd652eb93d96a1bd67b with merge 22bc64807a0970f8ddc68bc039ac923bb5c2867f...

bors-servo commented 6 years ago

:broken_heart: Test failed - status-travis

KiChjang commented 6 years ago

@taki-jaro No need for a new commit; you can just @bors-servo retry in order to re-trigger testing. Once you remove that commit, please @bors-servo r=jdm again.

bors-servo commented 6 years ago

:pushpin: Commit 1bff572 has been approved by `jdm``

bors-servo commented 6 years ago

:hourglass: Testing commit 1bff572592c391ef96014c277551a74c1ef5cd37 with merge 96e1c30652a3aa42b21a3121c06d227f07af454e...

KiChjang commented 6 years ago

@bors-servo r-

bors-servo commented 6 years ago

:sunny: Test successful - status-appveyor, status-travis State: approved= try=False

taki-jaro commented 6 years ago

@KiChjang Ok, thanks

taki-jaro commented 6 years ago

@bors-servo retry

taki-jaro commented 6 years ago

@bors-servo retry

taki-jaro commented 6 years ago

@KiChjang It doesn't seem to work I still have failed test from 22 hours ago, the 2 retry command I gave didin't restart the test

KiChjang commented 6 years ago

@taki-jaro When you push a new commit, the r+ state in homu is reset, which forces you to do another r+. So if I do @bors-servo r=jdm right now, it would Just Work.

bors-servo commented 6 years ago

:pushpin: Commit 3e5024a has been approved by jdm

bors-servo commented 6 years ago

:bulb: This pull request was already approved, no need to approve it again.

bors-servo commented 6 years ago

:pushpin: Commit 3e5024a has been approved by KiChjang

bors-servo commented 6 years ago

:hourglass: Testing commit 3e5024a3bcb4dafb71a32bd652eb93d96a1bd67b with merge d027dbb85f587343c06a869d7fab8ae5981d535f...

bors-servo commented 6 years ago

:sunny: Test successful - status-appveyor, status-travis Approved by: KiChjang Pushing d027dbb85f587343c06a869d7fab8ae5981d535f to master...