search

servo / rust-mozjs

DEPRECATED - moved to servo/mozjs instead.
Mozilla Public License 2.0
293 stars 122 forks source link

Require C++14 #423

Closed vyv03354 closed 6 years ago

vyv03354 commented 6 years ago

Currently C++14 features are unavailable due to explicit -std=c++11 switch. See also https://bugzilla.mozilla.org/show_bug.cgi?id=1451931

This change is Reviewable

bors-servo commented 6 years ago

:umbrella: The latest upstream changes (presumably #424) made this pull request unmergeable. Please resolve the merge conflicts.

KiChjang commented 6 years ago

Given #424, we're not using cmake anymore, and instead we're opting for using the cc crate.

jdm commented 6 years ago

@vyv03354 What was the motivation for this change? What C++ usage was prevented?

jdm commented 6 years ago

Oh, this was literally just upstreaming the change from https://bugzilla.mozilla.org/show_bug.cgi?id=1451931?