search

servo / rust-mozjs

DEPRECATED - moved to servo/mozjs instead.
Mozilla Public License 2.0
293 stars 117 forks source link

Get the mozjs crate to work with the mozjs_sys which uses bindgen #425

Closed asajeffrey closed 6 years ago

asajeffrey commented 6 years ago

This is the matching PR to https://github.com/servo/mozjs/pull/134 which runs bindgen on spidermonkey to produce Rust bindings.

This change is Reviewable

asajeffrey commented 6 years ago

cc @jdm

asajeffrey commented 6 years ago

This can land once https://github.com/servo/mozjs/pull/134 does.

asajeffrey commented 6 years ago

Oh I guess it makes sense to hold off for https://github.com/servo/mozjs/pull/135, since then we don't have to check in a patch entry in Cargo.toml.

asajeffrey commented 6 years ago

https://crates.io/crates/mozjs_sys/0.51.0 is published, so we can land this.

@bors-servo r=jdm

bors-servo commented 6 years ago

:pushpin: Commit 5f25fd6 has been approved by jdm

bors-servo commented 6 years ago

:hourglass: Testing commit 5f25fd68d512cd64957b326b84ec81e7fa0211f2 with merge 6d4c8b9d4d7cace8da8bd28779d56004fb3dc630...

bors-servo commented 6 years ago

:sunny: Test successful - status-appveyor, status-travis Approved by: jdm Pushing 6d4c8b9d4d7cace8da8bd28779d56004fb3dc630 to master...