search

servo / rust-mozjs

DEPRECATED - moved to servo/mozjs instead.
Mozilla Public License 2.0
293 stars 122 forks source link

Re-export IntoHandle #445

Closed CYBAI closed 5 years ago

CYBAI commented 5 years ago

When implementing rejectionhandled event, we'll need to add consumed rejection in task and we'll need to convert HandleObject into RawHandleObject which is js::jsapi::HandleObject. With exporting this trait, we can leverage the power of into_handle to do the conversion instead of writing a new method to get the RawHandleObject.

This change is Reviewable

jdm commented 5 years ago

r? @asajeffrey

asajeffrey commented 5 years ago

@bors-servo r+

bors-servo commented 5 years ago

:pushpin: Commit 261f5c0 has been approved by asajeffrey

jdm commented 5 years ago

@bors-servo r-

jdm commented 5 years ago

@bors-servo r=asajeffrey

bors-servo commented 5 years ago

:pushpin: Commit 261f5c0 has been approved by asajeffrey

jdm commented 5 years ago

@bors-servo retry

jdm commented 5 years ago

@bors-servo r=asajeffrey

bors-servo commented 5 years ago

:pushpin: Commit 9d5d8a9 has been approved by asajeffrey

bors-servo commented 5 years ago

:hourglass: Testing commit 9d5d8a9438e06fc025d927e12a1baf4b71647352 with merge c16e7e2473ff1203bc4510bed9d6618d14cc9d31...

bors-servo commented 5 years ago

:sunny: Test successful - status-appveyor, status-travis Approved by: asajeffrey Pushing c16e7e2473ff1203bc4510bed9d6618d14cc9d31 to master...