[#411] Add some tests for default-initialized roots - Githubissues

servo / rust-mozjs

DEPRECATED - moved to servo/mozjs instead.

Mozilla Public License 2.0

293 stars 122 forks source link

[#411] Add some tests for default-initialized roots #451

Closed bytesnail closed 5 years ago

bytesnail commented 5 years ago

At the current stage, I only completed the test code for JSVal; I need to know how to implement several other types of default values in order to complete all the test code.
The default value of JSVal's current implementation is undefined, so we should use the is_undefined() method to verify the result.

This change is

bytesnail commented 5 years ago

@jdm

I have merged these two methods together.

jdm commented 5 years ago

@bors-servo r+ Thanks! This looks great!

bors-servo commented 5 years ago

:pushpin: Commit b50cccf has been approved by jdm

bors-servo commented 5 years ago

:hourglass: Testing commit b50cccf7bc7bd83c0a23a200a6b886112b2ddff8 with merge cd98538039fd00bbab00501e29a418049d4412f3...

bors-servo commented 5 years ago

:broken_heart: Test failed - status-travis

jdm commented 5 years ago

@bors-servo r+

bors-servo commented 5 years ago

:pushpin: Commit d01b430 has been approved by jdm

bors-servo commented 5 years ago

:hourglass: Testing commit d01b43056eab161a6b9f10126b22f2d0e45b104a with merge e2d07dc606403212e61b57b7bac60b4b7d47e62d...

bors-servo commented 5 years ago

:sunny: Test successful - status-appveyor, status-travis Approved by: jdm Pushing e2d07dc606403212e61b57b7bac60b4b7d47e62d to master...

bytesnail commented 5 years ago

This is my first code commit under the servo organization. This is a good start. Thank you very much for your patience!

jdm commented 5 years ago

Thank you for your contribution!