search

servo / rust-mozjs

DEPRECATED - moved to servo/mozjs instead.
Mozilla Public License 2.0
293 stars 122 forks source link

Expose IntoMutableHandle API. #455

Closed jdm closed 5 years ago

jdm commented 5 years ago

This change is Reviewable

jdm commented 5 years ago

As far as I can tell not exposing this is just an oversight.

jdm commented 5 years ago

r? @asajeffrey

jdm commented 5 years ago

Ping @asajeffrey

asajeffrey commented 5 years ago

@bors-servo r+

bors-servo commented 5 years ago

:pushpin: Commit c80f664 has been approved by asajeffrey

bors-servo commented 5 years ago

:hourglass: Testing commit c80f664174ad25be4c4f89304f883bbf3de62508 with merge 464b4c4f057f3d8842b3a012b2d9af3f2d818e01...

bors-servo commented 5 years ago

:broken_heart: Test failed - checks-travis

CYBAI commented 5 years ago

@bors-servo retry

(Can bors retry travis? 🤔)

Caused by:
  [6] Couldn't resolve host name (Could not resolve host: crates.io)
/Users/travis/.travis/functions: line 524: 83321 Terminated: 15          travis_jigger "${!}" "${timeout}" "${cmd[@]}"
The command "CCACHE=$(which ccache) travis_wait cargo build --verbose $FEATURES" exited with 101.
jdm commented 5 years ago

It's easier to restart the single failed job in the travis interface.

CYBAI commented 5 years ago

hmm, seems I cannot restart the job for Travis in this repo 😖

bors-servo commented 5 years ago

:hourglass: Testing commit c80f664174ad25be4c4f89304f883bbf3de62508 with merge 36d53b8d62fe70dbfc52da1fb9b828da30fdf33c...

bors-servo commented 5 years ago

:sunny: Test successful - checks-travis, status-appveyor Approved by: asajeffrey Pushing 36d53b8d62fe70dbfc52da1fb9b828da30fdf33c to master...