search

servo / rust-mozjs

DEPRECATED - moved to servo/mozjs instead.
Mozilla Public License 2.0
293 stars 117 forks source link

Update to SpiderMonkey 66. #458

Closed jdm closed 5 years ago

jdm commented 5 years ago

This change is Reviewable

jdm commented 5 years ago

Depends on https://github.com/servo/mozjs/pull/172.

bors-servo commented 5 years ago

:umbrella: The latest upstream changes (presumably #461) made this pull request unmergeable. Please resolve the merge conflicts.

jdm commented 5 years ago

Windows error:

  = note: lld-link: error: undefined symbol: JSID_VOID
          >>> referenced by C:\Users\appveyor\.cargo\git\checkouts\mozjs-fa11ffc7d4f1cc2d\233235a\src\jsimpls.rs:55
          >>>               libmozjs_sys-82ed1c8753c8895b.rlib(mozjs_sys-82ed1c8753c8895b.mozjs_sys.c31j43od-cgu.1.rcgu.o):(_ZN9mozjs_sys7jsimpls96_$LT$impl$u20$core..default..Default$u20$for$u20$mozjs_sys..generated..root..JS..PropertyKey$GT$7default17h69604fc21c10c03eE)

error: aborting due to previous error
jdm commented 5 years ago

Linux/macOS debug and non-debugmozjs builds are succeeding. Windows builds are succeeding.

jdm commented 5 years ago

This is ready for review.

jdm commented 5 years ago

@bors-servo r=asajeffrey

bors-servo commented 5 years ago

:pushpin: Commit 4087d09 has been approved by asajeffrey

bors-servo commented 5 years ago

:hourglass: Testing commit 4087d0942aa016dd47bae5b5e0c2c51b7d4fb3df with merge 357d1db91e4e49c3f148fe05fdfae5f8f0834ca8...

bors-servo commented 5 years ago

:sunny: Test successful - checks-travis, status-appveyor Approved by: asajeffrey Pushing 357d1db91e4e49c3f148fe05fdfae5f8f0834ca8 to master...