search

servo / rust-mozjs

DEPRECATED - moved to servo/mozjs instead.
Mozilla Public License 2.0
293 stars 122 forks source link

fix deprecation warnings for `try!` and dyn traits #480

Closed r-52 closed 4 years ago

r-52 commented 4 years ago

this commit fixes some deprecation warnings that are caused by the old try!. Every part is replaced with the ? operator. At one part the compiler mentioned the deprecation:

trait objects without an explicit `dyn` are deprecated

which is also replaced.

This change is Reviewable

jdm commented 4 years ago

@bors-servo r+

bors-servo commented 4 years ago

:pushpin: Commit ce70b6f has been approved by jdm

bors-servo commented 4 years ago

:hourglass: Testing commit ce70b6fb4de3a5bd2545025dece1b93ce1309d41 with merge b5ed423214f6cc7f09fbb3c4c4b2108b00879ec6...

bors-servo commented 4 years ago

:broken_heart: Test failed - checks-travis

jdm commented 4 years ago

@bors-servo retry

bors-servo commented 4 years ago

:hourglass: Testing commit ce70b6fb4de3a5bd2545025dece1b93ce1309d41 with merge 9241cddedcbae901d9d39c38b81baa93d46b9a32...

bors-servo commented 4 years ago

:broken_heart: Test failed - checks-travis

bors-servo commented 4 years ago

:sunny: Test successful - checks-travis, status-appveyor Approved by: jdm Pushing 9241cddedcbae901d9d39c38b81baa93d46b9a32 to master...