Throw when failing to convert sequence inner values

servo / rust-mozjs

DEPRECATED - moved to servo/mozjs instead.

Mozilla Public License 2.0

293 stars 122 forks source link

Throw when failing to convert sequence inner values #485

Closed saschanaz closed 4 years ago

saschanaz commented 4 years ago

Returning Ok(ConversionResult::Failure) allows the code to try other conversion in a union type, but per the spec there is no such failover given that the type is iterable.

For https://github.com/servo/servo/issues/24406.

jdm commented 4 years ago

@bors-servo r+ Thanks!

bors-servo commented 4 years ago

:pushpin: Commit e24aad4 has been approved by jdm

bors-servo commented 4 years ago

:hourglass: Testing commit e24aad455ea4e338937c2b1ed290e7ef2074add7 with merge c2896b9c9f8681070890bc9582378472d0139b13...

bors-servo commented 4 years ago

:sunny: Test successful - checks-travis, status-appveyor Approved by: jdm Pushing c2896b9c9f8681070890bc9582378472d0139b13 to master...

CYBAI commented 4 years ago

Oops, I just found that maybe we need a version update for publishing a new version to include this patch?

nox commented 4 years ago

We don't really publish mozjs_sys and mozjs so shrug.