search

servo / rust-mozjs

DEPRECATED - moved to servo/mozjs instead.
Mozilla Public License 2.0
293 stars 122 forks source link

Pass StackCapture argument by pointer. #513

Closed jdm closed 4 years ago

jdm commented 4 years ago

This avoids a crash on Windows arm64. Depends on https://github.com/servo/mozjs/pull/253.

asajeffrey commented 4 years ago

You can r=me on this.

jdm commented 4 years ago

@bors-servo r=asajeffrey

bors-servo commented 4 years ago

:pushpin: Commit 0b64216 has been approved by asajeffrey

bors-servo commented 4 years ago

:hourglass: Testing commit 0b642165aff127ca09973a9c9b52c9e54b4d96b7 with merge b0280416a41d94cec13ae9efc3d6f28077f1d0f8...

bors-servo commented 4 years ago

:broken_heart: Test failed - checks-travis

jdm commented 4 years ago 
Assertion failure: is<N>(), at /Users/travis/build/servo/rust-mozjs/target/debug/build/mozjs_sys-67a74d10fa11392c/out/build/dist/include/mozilla/Variant.h:695

error: test failed, to rerun pass '--test capture_stack'

Yikes :/

jdm commented 4 years ago

This happens because the mozilla::Variant destructor runs when the C++ code overwrites the uninitialized value via the pointer :(

jdm commented 4 years ago

@bors-servo r=asajeffrey

bors-servo commented 4 years ago

:pushpin: Commit 20adfac has been approved by asajeffrey

bors-servo commented 4 years ago

:hourglass: Testing commit 20adfaca941055f03f4e52301474e12af73fb76f with merge 0caf5549cddbb34ad16abf35fb6bfbff824a4d14...

bors-servo commented 4 years ago

:sunny: Test successful - checks-travis, status-appveyor Approved by: asajeffrey Pushing 0caf5549cddbb34ad16abf35fb6bfbff824a4d14 to master...