Closed CYBAI closed 4 years ago
Btw, I just noticed the Microsoft documentation link in line 1072 is 404 now.
I tried to search it but looks like I can't find exactly same one.
But found 2 links might be related; ☝️ is any of them I should update to the comment?
Please file an issue about the broken doc link.
@bors-servo r+
:pushpin: Commit cc7aeda has been approved by jdm
:hourglass: Testing commit cc7aeda0e37f7757960c2a29c7d249398233b5da with merge 716dede8811ed525d9aab1e44cea392609b35d0a...
:sunny: Test successful - checks-travis, status-appveyor Approved by: jdm Pushing 716dede8811ed525d9aab1e44cea392609b35d0a to master...
While working on servo/servo#27026, we've noticed calling
GetScriptPrivate
will hit a CRASH consistently in Windows. jdm noticed that this is caused by "can't return JSValue by value on Windows"; thus, we need to expose these 2 glue methods so that we can handle theGetScriptPrivate
andGetModulePrivate
correctly.This will help servo/servo#27026.
We might want to handle the
ModulePrivate
much more correctly in the future so it might be worth adding it here as well?