search

servo / rust-mozjs

DEPRECATED - moved to servo/mozjs instead.
Mozilla Public License 2.0
293 stars 122 forks source link

CompileOptionsWrapper::new should accept a &str instead of a C string pointer #518

Closed jdm closed 4 years ago

jdm commented 4 years ago

It's too easy to misuse, otherwise. We can do the rust->c string conversion inside the constructor.

jdm commented 4 years ago

https://github.com/servo/rust-mozjs/blob/5a50c377a4e1f55abc1286b74100a4cc35adc789/src/rust.rs#L928