search

servo / rust-mozjs

DEPRECATED - moved to servo/mozjs instead.
Mozilla Public License 2.0
293 stars 117 forks source link

Update to mozjs 86. #534

Closed jdm closed 3 years ago

jdm commented 3 years ago

Integrates the work from https://github.com/servo/mozjs/pull/268.

jdm commented 3 years ago

@sagudev I did the intermediate work here; if you feel like using this branch to update Servo, go ahead!

sagudev commented 3 years ago

Actually, I have already everything prepared in my fork of this repo.

jdm commented 3 years ago

Oh, nice!

sagudev commented 3 years ago

How far is GitHub actions for Servo repo? The main reason I implemented GitHub Actions for servo/(rust-)mozjs is to quickly test changes in my own form. Travis kicked me out and never used Appvenoy before. Anything I can do there to speed up bringing GH actions to main servo repo?

jdm commented 3 years ago

https://github.com/servo/servo/pull/27865 is all of the work to date. The only thing stopping it from merging is solving the issue of Windows builds; we need to clone to the C:\ drive instead of the default because we run out of disk space, but that means we can't use the default checkout action and replicating that in the yml is tricky.

sagudev commented 3 years ago

I cloned servo/mozjs on windows to C drive before CARGO_HOME heck, but I forced pushed latter so all commits gone.

EDIT: This was in this repo and good new is that data is still in PR.

jdm commented 3 years ago

https://github.com/servo/rust-mozjs/pull/529/commits/67bd23f8b05511610f4d40435931651de3fa93bb

Oh, I never thought of doing a copy. That looks like a great solution!

sagudev commented 3 years ago

67bd23f

That's what I was talking about.