servo / rust-stb-image

Rust bindings to the awesome stb_image library
Other
68 stars 34 forks source link

Update from ancient gcc dependency to cc #98

Closed Jasper-Bekkers closed 2 years ago

Jasper-Bekkers commented 2 years ago

gcc was stuck in my dependency tree for a while, and this was the last remaining crate to use it. gcc has been renamed into cc and has seen significant improvements since then.

The reason I've updated it now is because gcc didn't pick up our build environment properly while cc does.

Manishearth commented 2 years ago

@bors-servo r+

bors-servo commented 2 years ago

:pushpin: Commit de72ca4 has been approved by Manishearth

bors-servo commented 2 years ago

:hourglass: Testing commit de72ca47b2371d0260f4a8a24fd5f5562a1f60ee with merge 71a24cd57575cec64d58a32aa507af58cb825b64...

jdm commented 2 years ago

This repo hasn't been migrated off of Travis yet.

bors-servo commented 2 years ago

:boom: Test timed out

Jasper-Bekkers commented 2 years ago

This repo hasn't been migrated off of Travis yet.

Not sure I fully understand this comment - should I switch this repo to github actions in this PR or is this an expectation that somebody else will pick up that work?

Manishearth commented 2 years ago

I opened https://github.com/servo/rust-stb-image/pull/99.