search

servo / rust-url

URL parser for Rust
https://docs.rs/url/
Apache License 2.0
1.31k stars 325 forks source link

Update the minimum rust-version to 1.51 to fix Rust 1.45.0 CI failure #786

Closed ridwanabdillahi closed 2 years ago

ridwanabdillahi commented 2 years ago

The Rust 1.45.0 CI job has started failing due to an update of the serde and serde_derive crates. The latest updates to these crates causes cargo to require the resolver feature which was unstable in the version of cargo shipped in the Rust 1.45.0 toolchain.

This feature has since been stabilized in the version of cargo shipped with the Rust 1.51.0 toolchain.

This change updates the minimum rust-version to Rust 1.51.0 and updates the github actions workflow to test against Rust 1.51.0 instead of Rust 1.45.0

Linked issue: https://github.com/servo/rust-url/issues/785

codecov-commenter commented 2 years ago

Codecov Report

Merging #786 (6353d50) into master (a72f83d) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #786   +/-   ##
=======================================
  Coverage   85.23%   85.23%           
=======================================
  Files          22       22           
  Lines        3894     3894           
=======================================
  Hits         3319     3319           
  Misses        575      575

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

valenting commented 2 years ago

Thank you!