set empty password tests

servo / rust-url

URL parser for Rust

https://docs.rs/url/

Apache License 2.0

1.31k stars 325 forks source link

set empty password tests #806

Closed raccmonteiro closed 1 year ago

raccmonteiro commented 1 year ago

Two tests regarding empty passwords and output of Url as_str()

raccmonteiro commented 1 year ago

what's wrong? The tests I included would not break this

qsantos commented 1 year ago

It looks like the pipeline caused because of a bug in the coverage job. Restarting it might be enough?

In any case, I have cherry-picked your commit in my own PR https://github.com/servo/rust-url/pull/825 to address https://github.com/servo/rust-url/issues/796. If this PR is merged first, I will just rebase my own branch.

bors-servo commented 1 year ago

:umbrella: The latest upstream changes (presumably a4633bed0c0150dfdf5707b94369b609cf90e099) made this pull request unmergeable. Please resolve the merge conflicts.

valenting commented 1 year ago

Resolved in https://github.com/servo/rust-url/pull/825