servo / rust-url

URL parser for Rust
https://docs.rs/url/
Apache License 2.0
1.27k stars 318 forks source link

Url is special #826

Closed qsantos closed 1 year ago

qsantos commented 1 year ago

This closes #800 by exposing Url::is_special

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 40.00% and project coverage change: -0.07 :warning:

Comparison is base (a4633be) 82.78% compared to head (5a7eddc) 82.71%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #826 +/- ## ========================================== - Coverage 82.78% 82.71% -0.07% ========================================== Files 20 20 Lines 3335 3339 +4 ========================================== + Hits 2761 2762 +1 - Misses 574 577 +3 ``` | [Impacted Files](https://codecov.io/gh/servo/rust-url/pull/826?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=servo) | Coverage Δ | | |---|---|---| | [url/src/lib.rs](https://codecov.io/gh/servo/rust-url/pull/826?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=servo#diff-dXJsL3NyYy9saWIucnM=) | `76.20% <0.00%> (-0.31%)` | :arrow_down: | | [url/src/parser.rs](https://codecov.io/gh/servo/rust-url/pull/826?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=servo#diff-dXJsL3NyYy9wYXJzZXIucnM=) | `81.59% <100.00%> (+0.02%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=servo). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=servo)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

qsantos commented 1 year ago

I have addressed the new linting rules in https://github.com/servo/rust-url/pull/825. I'll avoid moving the fix to this PR since there is already a discussion there. I'll rebase once #825 is merged.