Explicitly depend on serde_derive

servo / rust-url

URL parser for Rust

https://docs.rs/url/

Apache License 2.0

1.27k stars 318 forks source link

Explicitly depend on serde_derive #829

Closed Veykril closed 1 year ago

Veykril commented 1 year ago

The derive feature of serde puts serde after serde_derive in the build graph which can hurt compile times. Depending on serde_derive explicitly avoids this, and as the change is rather non-invasive I figured this might be okay to submit.

see https://github.com/rust-lang/rust-analyzer/pull/14450

Veykril commented 1 year ago

Apparently it is recommended to use the derive feature so I'll go ahead and close this, sorry for the noise