search

servo / rust-url

URL parser for Rust
https://docs.rs/url/
Apache License 2.0
1.31k stars 325 forks source link

Additional percent-encode sets #837

Open cryptoquick opened 1 year ago

cryptoquick commented 1 year ago

I've added some additional constants that should be useful for others.

I'd also recommend adding #721.

I've also corrected some docs generation warnings.

cryptoquick commented 1 year ago

Good point! Will do.

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.42%. Comparing base (11bb12f) to head (e2ebbf0). Report is 3 commits behind head on master.

:exclamation: Current head e2ebbf0 differs from pull request most recent head be685e1. Consider uploading reports for the commit be685e1 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #837 +/- ## ========================================== - Coverage 81.75% 81.42% -0.33% ========================================== Files 20 20 Lines 3551 3516 -35 ========================================== - Hits 2903 2863 -40 - Misses 648 653 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cryptoquick commented 1 year ago

Let me know if there's anything more I need to do in order to help get this in, thanks!

cyqsimon commented 1 week ago

Bump. Had to do some duplicate work in miniserve in lieu of this.

I see in UPGRADING.md that these sets were previously included but have since been removed, but I could not find a justification. Does someone know why this decision was made?

Regardless, I'm in favour of seeing these sets merged.