search

servo / rust-url

URL parser for Rust
https://docs.rs/url/
Apache License 2.0
1.27k stars 318 forks source link

Fix issues with file drives #839

Closed valenting closed 1 year ago

valenting commented 1 year ago

Fixes #838

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.28 :warning:

Comparison is base (206d378) 82.71% compared to head (21f32d6) 82.44%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #839 +/- ## ========================================== - Coverage 82.71% 82.44% -0.28% ========================================== Files 20 20 Lines 3339 3343 +4 ========================================== - Hits 2762 2756 -6 - Misses 577 587 +10 ``` | [Impacted Files](https://app.codecov.io/gh/servo/rust-url/pull/839?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=servo) | Coverage Δ | | |---|---|---| | [url/src/parser.rs](https://app.codecov.io/gh/servo/rust-url/pull/839?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=servo#diff-dXJsL3NyYy9wYXJzZXIucnM=) | `80.80% <100.00%> (-0.80%)` | :arrow_down: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/servo/rust-url/pull/839/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=servo)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Manishearth commented 1 year ago

@bors-servo r+

bors-servo commented 1 year ago

:pushpin: Commit 21f32d6 has been approved by Manishearth

bors-servo commented 1 year ago

:hourglass: Testing commit 21f32d64b735323880c2913c44e8f370a49518bb with merge c05541374800d4e571b57ace0c24bd0f68dc32cf...

valenting commented 1 year ago

@Manishearth not sure how the homu check is supposed to work if it's still waiting or hung - but I had changed the settings of this repo to require review before landing. Now it seems I don't have access to the rust-url settings - not sure if that was intentional or not. 🤷‍♂️ If you have any insights into the recent servo changes I'd love to have a chat.

bors-servo commented 1 year ago

:boom: Test timed out

Manishearth commented 1 year ago

@bors-servo retry

maybe the timeout was due to the merge problem, or osmething else.

@valenting Recently the Servo TSC performed a cleanup of perms since most people do not need GitHub perms. You can make a PR to the saltfs repo for homu perms, or ask on zulip. If you do feel the need for GitHub perms you should also ask on Zulip: I don't think the TSC has a concrete plan for how to do one-off GitHub perms but I expect they would want to keep track of it somehow.

bors-servo commented 1 year ago

:hourglass: Testing commit 21f32d64b735323880c2913c44e8f370a49518bb with merge 1b79622e781c30e46c6906dcd3a770ba19256b6f...

bors-servo commented 1 year ago

:boom: Test timed out