search

servo / rust-url

URL parser for Rust
https://docs.rs/url/
Apache License 2.0
1.31k stars 325 forks source link

Enable the GitHub merge queue #851

Closed mrobinson closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (93b8e2f) 82.43% compared to head (9fc081e) 82.43%.

:exclamation: Current head 9fc081e differs from pull request most recent head ed2324c. Consider uploading reports for the commit ed2324c to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #851 +/- ## ======================================= Coverage 82.43% 82.43% ======================================= Files 20 20 Lines 3348 3348 ======================================= Hits 2760 2760 Misses 588 588 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

mrobinson commented 1 year ago

Huh. Something is wrong as the final step passed even with an intermediate failure.

valenting commented 1 year ago

You need to rebase on the latest changes to get the checks to pass.

mrobinson commented 1 year ago

@valenting @lucacasonato Thanks for looking at this. In order to land changes now, simply click the "Merge when ready" button on pull requests. The merge style is set to "squash" right now, but let me know if you'd like it to be "rebase" instead which will preserve all commits in the PR instead of squashing them.

simonsan commented 1 year ago

2023-09-17 02_54_20-Enable the GitHub merge queue by mrobinson · Pull Request #851 · servo_rust-url

Setting up merge queue as well, I ask myself if the Result is needed in general or why you chose to have this job? Is it just personal preference?

mrobinson commented 1 year ago

You need a job to control whether the CI passes or fails. This Result job tries to do that by failing if any dependent job fails. I'm not sure if it's working on this case or not.

simonsan commented 1 year ago

You need a job to control whether the CI passes or fails. This Result job tries to do that by failing if any dependent job fails. I'm not sure if it's working on this case or not.

Wow, that would be indeed weird behaviour! It's true, I can't really read if it is needed or not from the docs: https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-a-merge-queue#failing-ci

I hope (for now, will test it), that a failing job is also seen as that for the merge queue. Thanks for the elaboration! 👍🏽