search

servo / rust-url

URL parser for Rust
https://docs.rs/url/
Apache License 2.0
1.27k stars 317 forks source link

Correct spelling mistake in `Position` docs #875

Closed sprocklem closed 8 months ago

sprocklem commented 8 months ago

The sentence in question was clearly intended to remark that the leading slash in the path is part of said path, but due to the missing "e" at the end of "Note", it (ungrammatically) says the opposite.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1158370) 81.42% compared to head (7d58821) 81.81%. Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #875 +/- ## ========================================== + Coverage 81.42% 81.81% +0.38% ========================================== Files 20 20 Lines 3516 3514 -2 ========================================== + Hits 2863 2875 +12 + Misses 653 639 -14 ``` | [Files](https://app.codecov.io/gh/servo/rust-url/pull/875?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=servo) | Coverage Δ | | |---|---|---| | [idna/src/uts46.rs](https://app.codecov.io/gh/servo/rust-url/pull/875?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=servo#diff-aWRuYS9zcmMvdXRzNDYucnM=) | `94.17% <100.00%> (-0.02%)` | :arrow_down: | | [url/src/lib.rs](https://app.codecov.io/gh/servo/rust-url/pull/875?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=servo#diff-dXJsL3NyYy9saWIucnM=) | `75.53% <ø> (+1.46%)` | :arrow_up: | | [url/src/parser.rs](https://app.codecov.io/gh/servo/rust-url/pull/875?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=servo#diff-dXJsL3NyYy9wYXJzZXIucnM=) | `81.70% <100.00%> (+0.23%)` | :arrow_up: | | [url/src/slicing.rs](https://app.codecov.io/gh/servo/rust-url/pull/875?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=servo#diff-dXJsL3NyYy9zbGljaW5nLnJz) | `91.30% <ø> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/servo/rust-url/pull/875/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=servo)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sprocklem commented 8 months ago

That lint failure is obviously not due to this documentation typo fix, and the same failure occurs without this PR.