Closed Skgland closed 7 months ago
Attention: 3 lines
in your changes are missing coverage. Please review.
Comparison is base (
912d716
) 81.85% compared to head (9b16473
) 81.75%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
It was possible to panic due to an overflow in build with panic on overflow (i.e. debug builds), if the input iterator contained more than
u32::MAX
elements. Which can happen an systems withtarget_pointer_width > 32
if a hugh string or char slice is passed toencode
orencode_str
respectively.Commit 1. adds a failing test Commit 2. fixes the implementation so that the test passes Commit 3. adds some early detection to
encode
andencode_str
to not waisted work allocating the String and iterating the input