Fix multiple issues on wasm32, and runs url tests in CI

servo / rust-url

URL parser for Rust

https://docs.rs/url/

Apache License 2.0

1.27k stars 317 forks source link

Fix multiple issues on wasm32, and runs url tests in CI #886

Closed micolous closed 3 months ago

micolous commented 7 months ago

This fixes multiple issues on wasm32-unknown-unknown:

Remove Url::socket_addrs() on wasm32-unknown-unknown. That function will never work – those platform API calls are not supported.
Disable unit tests which won't work on wasm32-unknown-unknown.
Run tests using wasm_bindgen_test on wasm32-unknown-unknown.
Remove panic::catch_unwind from wpt tests, as that conflicts with wasm-bindgen-test's panic handler.
Run url tests on wasm32-unknown-unknown in CI.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@a4dd58b). Click here to learn what that means.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #886 +/- ## ======================================= Coverage ? 81.88% ======================================= Files ? 20 Lines ? 3545 Branches ? 0 ======================================= Hits ? 2903 Misses ? 642 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

micolous commented 3 months ago

Any updates?