search

servo / rust-url

URL parser for Rust
https://docs.rs/url/
Apache License 2.0
1.31k stars 325 forks source link

perf: use NonZeroU32 for query and fragment start #933

Open DonIsaac opened 4 months ago

DonIsaac commented 4 months ago

Closes #930 and addresses feedback #931.

Reduces Url memory layout from 88 bytes to 80 bytes.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 68.00000% with 24 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@54346fa). Learn more about missing BASE report.

Files Patch % Lines
url/src/lib.rs 62.29% 23 Missing :warning:
url/src/parser.rs 85.71% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #933 +/- ## ======================================= Coverage ? 81.78% ======================================= Files ? 21 Lines ? 3574 Branches ? 0 ======================================= Hits ? 2923 Misses ? 651 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

DonIsaac commented 3 months ago

@valenting may I please have a review on this?