search

servo / rust-url

URL parser for Rust
https://docs.rs/url/
Apache License 2.0
1.27k stars 317 forks source link

v2.5.1 breaking crates.io CI #936

Closed Turbo87 closed 3 weeks ago

Turbo87 commented 3 weeks ago

The crates.io codebase received an automated pull request to update the url crate from v2.5.0 to v2.5.1, and it looks like that update it breaking our CI test suite. From the looks of it, some tests start failing and then the whole cargo test process just gives up and is silently killed, skipping all the remaining steps in the CI pipeline. Unfortunately, I don't have much more information yet, but to me this looks like a potential out-of-memory issue, although we're not actually using that many URL instances.

The change that stands out in the url release is https://github.com/servo/rust-url/pull/923, due to its size and significance, though I don't know yet whether this is the actual cause. It seems a bit unfortunate though that this was released in a bug-fix release, given the size of the diff.

If I can get more information out of our CI system I will update this issue accordingly.

Turbo87 commented 3 weeks ago

After deleting all caches and re-running CI it suddenly started working correctly, so this may have been a caching issue at some level. I'll close this issue since the root cause of the problem is apparently somewhere else.