search

servo / rust-url

URL parser for Rust
https://docs.rs/url/
Apache License 2.0
1.27k stars 317 forks source link

Upgrade to 2.5.1 breaks compilation on Windows #944

Closed zanieb closed 2 weeks ago

zanieb commented 2 weeks ago

In our test workflow for Windows, compilation fails during linking with the latest update. See logs.

= note: LINK : fatal error LNK1318: Unexpected PDB error; LIMIT (12)

Building with 1.78-x86_64-pc-windows-msvc.

Happy to provide more information if I can. I retried the test and it still failed. Per #936 I'll try dropping our crate cache.

zanieb commented 2 weeks ago

Possible this is related to https://github.com/servo/rust-url/issues/937?

zanieb commented 2 weeks ago

I've seen another failure at https://github.com/astral-sh/uv/pull/4370 which is isolated from this upgrade. I'll report back if it ends up being related somehow.

zanieb commented 2 weeks ago

I can confirm this was caused by an increase in disk consumption causing a confusing error due to our GitHub Runner optimizations on Windows.