`start_present` and `stop_present` aren't called by Servo

servo / rust-webvr

UNMAINTAINED - WebVR API implementation for servo.

Mozilla Public License 2.0

106 stars 23 forks source link

`start_present` and `stop_present` aren't called by Servo #56

Open asajeffrey opened 5 years ago

asajeffrey commented 5 years ago

Not sure if this is a servo issue or a rust-webvr issue, but the methods to start and stop presentation on a device are never called by servo. Shouldn't they be?

jdm commented 5 years ago

They're called internally in each backend:

https://github.com/servo/rust-webvr/blob/1280d8a8078fc9a0c13233c6c691d9a9d7e8aada/rust-webvr/src/api/vrexternal/android/display.rs#L166
https://github.com/servo/rust-webvr/blob/7b292186d85af794fb011e0c77b67acfdc69902e/rust-webvr/src/api/googlevr/display.rs#L113
https://github.com/servo/rust-webvr/blob/7b292186d85af794fb011e0c77b67acfdc69902e/rust-webvr/src/api/oculusvr/display.rs#L131

asajeffrey commented 5 years ago

Okay, that deals with start, what about stop? E.g. if there are system resources which need cleaned up?

MortimerGoro commented 5 years ago

yes, ideally we can make servo call those functions when WebXR sessions are started or stopped

asajeffrey commented 5 years ago

Created a Servo issue, since that's where the problem is... https://github.com/servo/servo/issues/22924