search

servo / saltfs

Salt Stack Filesystem
Apache License 2.0
56 stars 107 forks source link

Add mstange to reviewers. #1007

Closed mstange closed 3 years ago

mstange commented 3 years ago

I would like to be able to review changes to the various macOS and OpenGL crates that WebRender depends on.

r? @jdm

jdm commented 3 years ago

@mstange Is that https://github.com/servo/core-foundation-rs/ and https://github.com/servo/gleam/, or are there any others? It would be cleaner to add you to the reviewers list for the specific crates.

mstange commented 3 years ago

Yes, those two, and core-graphics-rs + core-text-rs.

jdm commented 3 years ago

Ok, if you could:

jdm commented 3 years ago

(homu only cares about github repositories, and all the macOS crates live in a workspace in the core-foundation-rs repo now)

mstange commented 3 years ago

Ah, I see. I'll make that change.

mstange commented 3 years ago

I've updated the PR.

jdm commented 3 years ago

@bors-servo r+

bors-servo commented 3 years ago

:pushpin: Commit 3550f84 has been approved by jdm

bors-servo commented 3 years ago

:hourglass: Testing commit 3550f84a71a95820fa29a937ba47abe4d07817b3 with merge ee857f6fe028ac083f093399d64afa1543450a79...

bors-servo commented 3 years ago

:broken_heart: Test failed - checks-travis

jdm commented 3 years ago

@bors-servo r+

bors-servo commented 3 years ago

:bulb: This pull request was already approved, no need to approve it again.

bors-servo commented 3 years ago

:pushpin: Commit 3550f84 has been approved by jdm

bors-servo commented 3 years ago

:hourglass: Testing commit 3550f84a71a95820fa29a937ba47abe4d07817b3 with merge 77e01b1578ee7d152d94e89656feee10ad63f31a...

bors-servo commented 3 years ago

:sunny: Test successful - checks-travis Approved by: jdm Pushing 77e01b1578ee7d152d94e89656feee10ad63f31a to master...