servo / saltfs

Salt Stack Filesystem
Apache License 2.0
56 stars 107 forks source link

intermittent-tracker: deploy servo/intermittent-tracker#7 and #8 #1036

Closed delan closed 1 year ago

delan commented 1 year ago

This patch fixes intermittent-tracker upgrades, which weren’t actually being deployed due to pip --upgrade behaviour,

$ cat ~servo/intermittent-tracker/_venv/lib/python*/site-packages/intermittent_tracker-*.dist-info/direct_url.json
{"url": "https://github.com/servo/intermittent-tracker", "vcs_info": {"commit_id": "85d047284df38dbb8ea7e9e4fe26ddaa4bf0a6a7", "requested_revision": "85d047284df38dbb8ea7e9e4fe26ddaa4bf0a6a7", "vcs": "git"}}

will deploy servo/intermittent-tracker#7 and servo/intermittent-tracker#8, and pins deps to the new requirements.txt to avoid inadvertent upgrades, which are more likely now that we use pip --force-reinstall rather than pip --upgrade.

Unrelated to this, we also update the README to point to docs/salt.md, and update the salt docs links there.

jdm commented 1 year ago

This failed deploy:

----------
          ID: /home/servo/intermittent-tracker/requirements.txt
    Function: file.managed
      Result: False
     Comment: Unable to verify upstream hash of source file https://github.com/servo/intermittent-tracker/raw/f0ada1bd444f800f9916e97789452d261fc707e7/requirements.txt, please set source_hash or set skip_verify to True
     Started: 12:03:09.700834
    Duration: 2.946 ms
     Changes:
----------
jdm commented 1 year ago

When I work around that with skip_verify: True, I get:

----------
          ID: intermittent-tracker
    Function: pip.installed
      Result: False
     Comment: Unable to process requirements file "['/home/servo/intermittent-tracker/requirements.txt']" Error: Collecting certifi==2022.12.7
                Using cached certifi-2022.12.7-py3-none-any.whl (155 kB)
              Collecting cffi==1.15.1
                Using cached cffi-1.15.1-cp36-cp36m-manylinux_2_5_x86_64.manylinux1_x86_64.whl (402 kB)
              Collecting charset-normalizer==3.0.1
                Using cached charset_normalizer-3.0.1-cp36-cp36m-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (162 kB) ERROR: Could not find a version that satisfies the requirement click==8.1.3
              ERROR: No matching distribution found for click==8.1.3
     Started: 12:15:45.686988
    Duration: 1592.399 ms
     Changes:
delan commented 1 year ago

@jdm yeah, i noticed that while deploying this morning, and when i worked around those in /tmp/salt-testing-root to see what else i would need to change, i then got an sqlite syntax error, which suggests that my code isn’t actually compatible with the sqlite in python 3.6, so i ended up reverting to the old version. i’ll investigate further on monday :)