search

servo / saltfs

Salt Stack Filesystem
Apache License 2.0
56 stars 107 forks source link

Re-add additional reviewers for rust-url #1048

Closed lucacasonato closed 1 year ago

lucacasonato commented 1 year ago

Hey, during the recent Servo TSC Github permission cleanup, @valenting and I lost access to rust-url to do reviews. We have been maintaining it for the past year and a bit, and it would be great to have review access again. Is this the right way?

lucacasonato commented 1 year ago

My main issue is the lack of my ability to do "Request reviews" now.

jdm commented 1 year ago

@bors-servo r+

bors-servo commented 1 year ago

:pushpin: Commit 56be29c has been approved by jdm

bors-servo commented 1 year ago

:hourglass: Testing commit 56be29c3331e7ef9d319fa07d97b37ef924670c8 with merge 77c80b18f91b686993e8ae1a9a3f8ee58a889d73...

bors-servo commented 1 year ago

:umbrella: The latest upstream changes (presumably a15e5098eb834501dbb67c2e54bdc281c0035b5d) made this pull request unmergeable. Please resolve the merge conflicts.

bors-servo commented 1 year ago

:boom: Test timed out

jdm commented 1 year ago

With the change to use merge queues this will not be needed.

lucacasonato commented 1 year ago

Great, thanks